discrepancy function #428
Open
discrepancy function #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs some tests skipped or something - uses extend_edges, which isn't in tskit yet. |
|
TODO: change weighted RMSE to be log-time rather than times. |
petrelharp
force-pushed
the
discrepancy
branch
from
e508a6e
to
cfbb887
Compare
|
I've started on this, and am having import issues. However: thinking more, I am coming around to putting this elsewhere - I don't think we actually should have the dissimilarity/discrepancy function in tsdate, since dissimilarity is all about spans, not dates. I'll move it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased version of #317.
TODO: @nspope will de-duplicate some of the stuff here that's shared between
discrepancy.pyandevaluation.py; and betweentests/test_evaluation.pyandtests/test_discrepancy.py.